Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3061 Fix nullability warnings #3063

Merged
merged 18 commits into from
Feb 26, 2025
Merged

Conversation

ewoutkramer
Copy link
Member

PR #3061 had added nullability to the generated POCOs, which caused a large amound of errors/warnings in our codebase. This PR fixes these warnings/errors.

⚠️ Make sure you review and pull #3062 first.

Kasdejong and others added 6 commits February 26, 2025 14:02
…nto 3061-fix-nullability-warnings

# Conflicts:
#	src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
#	src/Hl7.Fhir.Conformance/Model/ElementDefinitionExtensions.cs
#	src/Hl7.Fhir.Conformance/Specification/Source/Summary/ArtifactSummaryHarvesters.cs
#	src/Hl7.Fhir.Shims.Base/Model/StructureDefinition.cs
@Kasdejong
Copy link
Member

I don't know what happened here. Git diff shows only this branch's diff, but github seems to disagree. Something with 2 point vs 3 point diff?

@ewoutkramer
Copy link
Member Author

ewoutkramer commented Feb 26, 2025

Rebase happened.....

@ewoutkramer ewoutkramer changed the base branch from 3061-add-nullability to develop-6.0 February 26, 2025 15:57
@ewoutkramer ewoutkramer merged commit 8f5e511 into develop-6.0 Feb 26, 2025
14 checks passed
@ewoutkramer ewoutkramer deleted the 3061-fix-nullability-warnings branch February 26, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants