Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data from proof. #371

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Use data from proof. #371

merged 1 commit into from
Dec 3, 2024

Conversation

cabrador
Copy link
Collaborator

@cabrador cabrador commented Dec 3, 2024

This PR fixes RPC method GetProof such that it uses data from already extracted proof instead of calling the state again.

Copy link
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I would be curious whether extracting this information from the proof is actually faster fetching it from the DB. It might require extra time for RLP decoding and checking hashes. But these premature optimization considerations we should ignore until we actually see that this causes problems. Reading data from the proof is definitely the cleaner implementation.

@cabrador cabrador merged commit d7fc6bf into develop Dec 3, 2024
2 checks passed
@cabrador cabrador deleted the c/fix-get-proof-rpc branch December 3, 2024 15:49
wsodsong pushed a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants