Use data from proof. #371
Merged
Use data from proof. #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabrador
requested review from
jmpike,
thaarok,
HerbertJordan and
jenikd
as code owners
HerbertJordan
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Looks good to me.
I would be curious whether extracting this information from the proof is actually faster fetching it from the DB. It might require extra time for RLP decoding and checking hashes. But these premature optimization considerations we should ignore until we actually see that this causes problems. Reading data from the proof is definitely the cleaner implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes RPC method
GetProofsuch that it uses data from already extracted proof instead of calling the state again.