Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test checking the support for subscribing to log events #369

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

HerbertJordan
Copy link
Collaborator

This PR adds an initial test to verify that subscribing for log events through the web-socket interface is supported.

Tests that should follow:

  • check that filter criteria are supported
  • check that subscriptions for new head-blocks is working
  • check proper isolation between multiple subscriptions
  • ...

Copy link
Collaborator

@jenikd jenikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding ws test

@HerbertJordan HerbertJordan force-pushed the herbert/add_test_for_log_subscriptions branch from b64b635 to 07363f7 Compare December 3, 2024 10:46
@HerbertJordan HerbertJordan merged commit e0b538f into develop Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants