feature(async): ppp support using embassy-net-ppp & embassy-at-cmux #131
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
1 error and 33 warnings
Build & Test
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
|
rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
unused `core::result::Result` that must be used:
src/asynch/runner.rs#L492
warning: unused `core::result::Result` that must be used
--> src/asynch/runner.rs:492:21
|
492 | self.handle_urc(event).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
|
492 | let _ = self.handle_urc(event).await;
| +++++++
|
redundant closure:
src/asynch/state.rs#L343
warning: redundant closure
--> src/asynch/state.rs:343:22
|
343 | .map_err(|x| Error::SubscriberOverflow(x))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Error::SubscriberOverflow`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
the following explicit lifetimes could be elided: 'd:
src/asynch/state.rs#L247
warning: the following explicit lifetimes could be elided: 'd
--> src/asynch/state.rs:247:16
|
247 | pub fn new_ppp<'d>(state: &'d mut State) -> Runner<'d> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
247 - pub fn new_ppp<'d>(state: &'d mut State) -> Runner<'d> {
247 + pub fn new_ppp(state: &mut State) -> Runner<'_> {
|
|
redundant closure:
src/asynch/state.rs#L221
warning: redundant closure
--> src/asynch/state.rs:221:22
|
221 | .map_err(|x| Error::SubscriberOverflow(x))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Error::SubscriberOverflow`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
redundant closure:
src/asynch/state.rs#L208
warning: redundant closure
--> src/asynch/state.rs:208:22
|
208 | .map_err(|x| Error::SubscriberOverflow(x))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Error::SubscriberOverflow`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
unneeded `return` statement:
src/asynch/runner.rs#L891
warning: unneeded `return` statement
--> src/asynch/runner.rs:891:9
|
891 | return Err(Error::ContextActivationTimeout);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
891 - return Err(Error::ContextActivationTimeout);
891 + Err(Error::ContextActivationTimeout)
|
|
unneeded `return` statement:
src/asynch/runner.rs#L670
warning: unneeded `return` statement
--> src/asynch/runner.rs:670:9
|
670 | return Ok(false);
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
670 - return Ok(false);
670 + Ok(false)
|
|
redundant guard:
src/asynch/runner.rs#L339
warning: redundant guard
--> src/asynch/runner.rs:339:43
|
339 | Ok(PinStatus { code }) if code == PinStatusCode::Ready => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards
= note: `#[warn(clippy::redundant_guards)]` on by default
help: try
|
339 - Ok(PinStatus { code }) if code == PinStatusCode::Ready => {
339 + Ok(PinStatus { code: PinStatusCode::Ready }) => {
|
|
redundant closure:
src/asynch/control.rs#L59
warning: redundant closure
--> src/asynch/control.rs:59:22
|
59 | .map_err(|e| Error::Atat(e))
| ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Error::Atat`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
redundant closure:
src/asynch/control.rs#L50
warning: redundant closure
--> src/asynch/control.rs:50:22
|
50 | .map_err(|e| Error::Atat(e))
| ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Error::Atat`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
method `init` is never used:
src/asynch/control.rs#L22
warning: method `init` is never used
--> src/asynch/control.rs:22:25
|
17 | impl<'a, AT: AtatClient> Control<'a, AT> {
| ---------------------------------------- method in this implementation
...
22 | pub(crate) async fn init(&mut self) -> Result<(), Error> {
| ^^^^
|
function `kill_time` is never used:
src/module_timing.rs#L56
warning: function `kill_time` is never used
--> src/module_timing.rs:56:8
|
56 | pub fn kill_time() -> Option<Duration> {
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
unused import: `crate::command::system_features::SetPowerSavingControl`:
src/asynch/runner.rs#L25
warning: unused import: `crate::command::system_features::SetPowerSavingControl`
--> src/asynch/runner.rs:25:5
|
25 | use crate::command::system_features::SetPowerSavingControl;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `crate::command::system_features::types::PowerSavingMode`:
src/asynch/runner.rs#L24
warning: unused import: `crate::command::system_features::types::PowerSavingMode`
--> src/asynch/runner.rs:24:5
|
24 | use crate::command::system_features::types::PowerSavingMode;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `SetReportMobileTerminationError`:
src/asynch/runner.rs#L20
warning: unused import: `SetReportMobileTerminationError`
--> src/asynch/runner.rs:20:62
|
20 | use crate::command::mobile_control::{SetModuleFunctionality, SetReportMobileTerminationError};
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `TerminationErrorMode`:
src/asynch/runner.rs#L19
warning: unused import: `TerminationErrorMode`
--> src/asynch/runner.rs:19:71
|
19 | use crate::command::mobile_control::types::{Functionality, ResetMode, TerminationErrorMode};
| ^^^^^^^^^^^^^^^^^^^^
|
unused import: `crate::command::ip_transport_layer::SetHexMode`:
src/asynch/runner.rs#L18
warning: unused import: `crate::command::ip_transport_layer::SetHexMode`
--> src/asynch/runner.rs:18:5
|
18 | use crate::command::ip_transport_layer::SetHexMode;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `crate::command::ip_transport_layer::types::HexMode`:
src/asynch/runner.rs#L17
warning: unused import: `crate::command::ip_transport_layer::types::HexMode`
--> src/asynch/runner.rs:17:5
|
17 | use crate::command::ip_transport_layer::types::HexMode;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `crate::command::gpio::SetGpioConfiguration`:
src/asynch/runner.rs#L16
warning: unused import: `crate::command::gpio::SetGpioConfiguration`
--> src/asynch/runner.rs:16:5
|
16 | use crate::command::gpio::SetGpioConfiguration;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused imports: `GetCCID`, `GetFirmwareVersion`, `GetModelId`:
src/asynch/runner.rs#L14
warning: unused imports: `GetCCID`, `GetFirmwareVersion`, `GetModelId`
--> src/asynch/runner.rs:14:31
|
14 | use crate::command::general::{GetCCID, GetFirmwareVersion, GetModelId};
| ^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^
|
unused imports: `SetCircuit108Behaviour`, `SetCircuit109Behaviour`, `SetFlowControl`:
src/asynch/runner.rs#L10
warning: unused imports: `SetCircuit108Behaviour`, `SetCircuit109Behaviour`, `SetFlowControl`
--> src/asynch/runner.rs:10:31
|
10 | use crate::command::control::{SetCircuit108Behaviour, SetCircuit109Behaviour, SetFlowControl};
| ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^
|
unused imports: `Circuit108Behaviour`, `Circuit109Behaviour`, `FlowControl`:
src/asynch/runner.rs#L9
warning: unused imports: `Circuit108Behaviour`, `Circuit109Behaviour`, `FlowControl`
--> src/asynch/runner.rs:9:38
|
9 | use crate::command::control::types::{Circuit108Behaviour, Circuit109Behaviour, FlowControl};
| ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^
|
unused imports: `Duration`, `with_timeout`:
src/asynch/control.rs#L5
warning: unused imports: `Duration`, `with_timeout`
--> src/asynch/control.rs:5:20
|
5 | use embassy_time::{with_timeout, Duration};
| ^^^^^^^^^^^^ ^^^^^^^^
|
unused import: `core::task::Poll`:
src/asynch/control.rs#L2
warning: unused import: `core::task::Poll`
--> src/asynch/control.rs:2:5
|
2 | use core::task::Poll;
| ^^^^^^^^^^^^^^^^
|
unused import: `core::future::poll_fn`:
src/asynch/control.rs#L1
warning: unused import: `core::future::poll_fn`
--> src/asynch/control.rs:1:5
|
1 | use core::future::poll_fn;
| ^^^^^^^^^^^^^^^^^^^^^
|
unused import: `heapless::String`:
src/config.rs#L3
warning: unused import: `heapless::String`
--> src/config.rs:3:5
|
3 | use heapless::String;
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
unneeded sub `cfg` when there is only one condition:
src/asynch/runner.rs#L247
warning: unneeded sub `cfg` when there is only one condition
--> src/asynch/runner.rs:247:15
|
247 | #[cfg(any(feature = "toby-r2"))]
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "toby-r2"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
|
unneeded sub `cfg` when there is only one condition:
src/config.rs#L105
warning: unneeded sub `cfg` when there is only one condition
--> src/config.rs:105:11
|
105 | #[cfg(any(feature = "automatic-apn"))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "automatic-apn"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
= note: `#[warn(clippy::non_minimal_cfg)]` on by default
|
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Build & Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build & Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|