Update porting lib from legacy to new 1.20.1 branch #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current Issues:
|
|
Its because "porting_lib:loader": "porting_lib:obj" needs to be changed to "loader": "porting_lib:obj", |
|
That change should not be made, support for the new field should be re-added to porting lib |
|
I'm wondering if there will be any issues related to fake players |
should be fine, the porting lib -> fapi fake player change was pretty seamless, but testing should be done anyway |
|
The run can be ran again and then this can be tested/merged main things to test are fake players & deployers killing mobs |
Closed
|
Thanks for handling this |
TropheusJ
merged commit c298d95
into
Fabricators-of-Create:mc1.20.1/fabric/dev
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.