we did this fix in june what happened to it

fix #1633, fix #1637
Fabricators-of-Create · Nov 23, 2024 · 1557bb0 · 1557bb0
1 parent ff60e93
commit 1557bb0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/FABRIC_CHANGELOG.txt b/FABRIC_CHANGELOG.txt
@@ -20,6 +20,7 @@ Change logging starts below:
 - Fix nonsense fluid unit option when display links measured items (#995)
 - Fix copycat panels with framed glass not hiding faces when using sodium (#1540)
 - Fix filtered Smart Observers stopping listing matching items after finding 1 non-matching item (#996)
+- Fix incorrect capacities on large storages (#1633, #1637)
 - Merge in 0.5.1.g/h (https://github.com/Creators-of-Create/Create/wiki/0.5.1g-&-h)
 - Merge in 0.5.1.i (https://github.com/Creators-of-Create/Create/wiki/0.5.1i)
 - Merge in 0.5.1.j (https://github.com/Creators-of-Create/Create/wiki/0.5.1j)
diff --git a/...java/com/simibubi/create/content/redstone/thresholdSwitch/ThresholdSwitchBlockEntity.java b/...java/com/simibubi/create/content/redstone/thresholdSwitch/ThresholdSwitchBlockEntity.java
@@ -146,8 +146,8 @@ public void updateCurrentLevel() {
 					invVersionTracker.awaitNewVersion(inv);
 					try (Transaction t = TransferUtil.getTransaction()) {
 						for (StorageView<ItemVariant> view : inv.iterable(t)) {
-							// fabric: compat is unused, skip it
-							long space = Math.min(view.getResource().getItem().getMaxStackSize(), view.getCapacity());
+							// fabric: forge also checks for item max stack size, we should just trust capacity on fabric though.
+							long space = view.getCapacity();
 							long count = view.getAmount();
 							if (space == 0)
 								continue;