Fixed spline interp problem #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profxj
requested changes
Jan 9, 2024
zdm/energetics.py
Outdated
|
|
||
|
|
||
|
|
||
| def test_spline_accuracy(gamma = -1.5837, Ntest = 100): |
There was a problem hiding this comment.
please move this to a file in the tests/ folder
There was a problem hiding this comment.
extra credit if you get it to run under CI
zdm/energetics.py
Outdated
|
|
||
| def time_splines(gamma = -1.5837, Ntimetest = 100000, Nreps=100): |
There was a problem hiding this comment.
Done! In same script
There was a problem hiding this comment.
(in theory, I could split this into a performance check file, but too lazy, since we haven't really paid attention to performance checks in any systematic way - should re-do these at some point)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor changes to the behaviour of spline interpolation (interp in log space now), and changed 1e-2 to 1e-5 for a "small" number in survey.py. Also a spline performance test routine added. See SLACK for details.