Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cohort constraint to valueset levels to address issue #304 #306

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

hyi
Copy link
Collaborator

@hyi hyi commented Mar 1, 2024

This PR is to fix issue #304 which has already been verified and closed by @karafecho.

@hyi
Copy link
Collaborator Author

hyi commented Mar 1, 2024

@maximusunc This PR probably falls into hard-to-understand-what-I-am-doing category. Looking into that issue #304 and my comments may help a bit, but let me know if you see anything that does not look right.

@hyi hyi requested a review from maximusunc March 1, 2024 16:01
Copy link
Collaborator

@maximusunc maximusunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! I don't really understand what's going on, but at face value, the code looks to be in good order.

@hyi hyi merged commit 8b62d13 into master Mar 1, 2024
1 check passed
@hyi hyi deleted the valueset-with-cohort-constraint branch March 1, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants