Resolved the issue where the custom database prefix was lost after th… #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e primary cluster created the database.
l-jelly
force-pushed
the
hive-3.x-prefix
branch
from
b130c8c to
f3d9228
Compare
patduin
reviewed
Feb 10, 2025
| @@ -74,7 +74,7 @@ public void databaseCreatedNotification(String name) { | |||
| AbstractMetaStore newMetaStore; | |||
| if (metaStore instanceof PrimaryMetaStore) { | |||
| newMetaStore = new PrimaryMetaStore(metaStore.getName(), metaStore.getRemoteMetaStoreUris(), | |||
| metaStore.getAccessControlType(), newWritableDatabaseWhiteList); | |||
| metaStore.getDatabasePrefix(), metaStore.getAccessControlType(), newWritableDatabaseWhiteList); | |||
There was a problem hiding this comment.
please add a test on this class: DatabaseWhitelistAccessControlHandlerTest
patduin
reviewed
Feb 10, 2025
| @@ -55,7 +55,7 @@ public void databaseCreatedNotification(String name) { | |||
| AbstractMetaStore newMetaStore; | |||
| if (metaStore instanceof PrimaryMetaStore) { | |||
| newMetaStore = new PrimaryMetaStore(metaStore.getName(), metaStore.getRemoteMetaStoreUris(), | |||
| metaStore.getAccessControlType()); | |||
| metaStore.getDatabasePrefix(), metaStore.getAccessControlType()); | |||
There was a problem hiding this comment.
please add a test in here: ReadWriteCreateAccessControlHandlerTest
patduin
requested changes
Feb 10, 2025
OK, I'll add it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e primary cluster created the database.
📝
Configure the primary-meta-store.database-prefix: usercluster2_ for the primary database. Connect to waggle-dance through hs2 and execute create database xxx. The primary database prefix is lost when showing databases.
🔗 Related Issues