feat: add skeleton code for window functions and expressions #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3812 will not alter performanceComparing Summary
|
f4t4nt
force-pushed
the
feat/window-functions-skeleton
branch
from
8023a87 to
71c5fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a Draft PR so others can easily view the API I'm writing
Description
Adds skeleton code for window functions in Daft, focusing on the Python-side API structure. Changes include:
Added
Windowclass with basic window specification stubs:partition_by(),order_by()rows_between(),range_between()Added
over()method to Expression class for applying window functionsThe actual implementations will be added in Rust in subsequent PRs. This PR only establishes the Python API structure to allow the test files to compile.
Testing
Added test files under tests/window/ that define the expected behavior for various window operations. Tests currently have placeholder assertions that will be updated once the Rust implementations are added.