Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVEX-223] Add support for changing the root certificate #191

Merged

Conversation

w1am
Copy link

@w1am w1am commented Feb 6, 2025

This pull request introduces support for specifying a custom TLS CA file in the eventstore crate. It includes changes to the ClientSettings struct, updates to the connection parsing logic, and new tests to validate the functionality.

Key changes:

TLS CA File Support:

  • eventstore/src/grpc.rs: Added tls_ca_file field to ClientSettings struct and updated related methods to handle this new field. This includes adding a getter method and updating the parse_from_url function to parse the tlsCaFile parameter from the connection string.
  • eventstore/src/grpc.rs: Modified NodeConnection::new to load the custom TLS CA file if provided, otherwise, it falls back to loading the platform certificates.

@w1am w1am force-pushed the DEVEX-223-Rust-client-Supports-changing-the-root-certificate branch from 85a2301 to dfce394 Compare February 6, 2025 12:02
@w1am w1am force-pushed the DEVEX-223-Rust-client-Supports-changing-the-root-certificate branch from dfce394 to b2db626 Compare February 6, 2025 12:15
@w1am w1am changed the title Add support for changing the root certificate [DEVEX-223] Add support for changing the root certificate Feb 6, 2025
@w1am w1am requested a review from YoEight February 6, 2025 13:55
@YoEight YoEight merged commit 94569bc into master Feb 7, 2025
40 checks passed
@YoEight YoEight deleted the DEVEX-223-Rust-client-Supports-changing-the-root-certificate branch February 7, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants