setting adminCheck to false by default (#4233)

Co-authored-by: cthulhuplus <brookswm@gmail.com>
Enterprise-CMCS · Jul 27, 2022 · 78e8667 · 78e8667
1 parent b6ea9e9
commit 78e8667
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 40 deletions.
diff --git a/e2e/cypress/helpers/apd/key-state-personnel.js b/e2e/cypress/helpers/apd/key-state-personnel.js
@@ -5,20 +5,20 @@ export const testDefaultKeyStatePersonnel = () => {
     cy.url().should('contain', '/state-profile');
     cy.findByRole('heading', { name: /Key State Personnel/i }).should('exist');
 
-    cy.contains('Provide the name of the State Medicaid Director.');
-    cy.contains('Provide the email address of the State Medicaid Director.');
-    cy.contains('Provide a valid phone number for the State Medicaid Director.');
-    cy.contains('Provide a mailing street address for the Medicaid office.');
-    cy.contains('Provide a city name.');
-    cy.contains('Provide a zip code.');
+    // cy.contains('Provide the name of the State Medicaid Director.');
+    // cy.contains('Provide the email address of the State Medicaid Director.');
+    // cy.contains('Provide a valid phone number for the State Medicaid Director.');
+    // cy.contains('Provide a mailing street address for the Medicaid office.');
+    // cy.contains('Provide a city name.');
+    // cy.contains('Provide a zip code.');
 
     cy.get('input[name="medicaidDirector.name"]')
       .clear()
       .should('have.text', '');
 
     cy.get('input[name="medicaidDirector.email"]')
       .clear()
-      .should('have.text', '')
+      .should('have.text', '');
 
     cy.get('input[name="medicaidDirector.phone"]')
       .clear()
@@ -32,13 +32,9 @@ export const testDefaultKeyStatePersonnel = () => {
       .clear()
       .should('have.text', '');
 
-    cy.get('input[name="medicaidOffice.city"]')
-      .clear()
-      .should('have.text', '');
+    cy.get('input[name="medicaidOffice.city"]').clear().should('have.text', '');
 
-    cy.get('input[name="medicaidOffice.zip"]')
-      .clear()
-      .should('have.text', '');
+    cy.get('input[name="medicaidOffice.zip"]').clear().should('have.text', '');
 
     cy.get('select[name="medicaidOffice.state"]')
       .invoke('val', '')
@@ -116,13 +112,9 @@ export const testKeyStatePersonnelWithData = years => {
 
       cy.findByRole('button', { name: /Add Primary Contact/i }).click();
 
-      cy.get('[data-cy="key-person-0__name"]')
-        .clear()
-        .type(userData[1].name);
+      cy.get('[data-cy="key-person-0__name"]').clear().type(userData[1].name);
 
-      cy.get('[data-cy="key-person-0__email"]')
-        .clear()
-        .type(userData[1].email);
+      cy.get('[data-cy="key-person-0__email"]').clear().type(userData[1].email);
 
       cy.get('[data-cy="key-person-0__position"]')
         .clear()
@@ -144,7 +136,7 @@ export const testKeyStatePersonnelWithData = years => {
         });
       cy.get('.form-and-review-list')
         .findAllByRole('button', { name: /Edit/i })
-        .click()
+        .click();
 
       // Toggle to see if the FFY cost prompts appear/disappear
       cy.get('input[type="radio"][value="yes"]').check({ force: true });
@@ -164,13 +156,9 @@ export const testKeyStatePersonnelWithData = years => {
     cy.findByRole('button', { name: /Add Key Personnel/i }).click();
 
     cy.fixture('users').then(userData => {
-      cy.get('[data-cy="key-person-1__name"]')
-        .clear()
-        .type(userData[2].name);
+      cy.get('[data-cy="key-person-1__name"]').clear().type(userData[2].name);
 
-      cy.get('[data-cy="key-person-1__email"]')
-        .clear()
-        .type(userData[2].email);
+      cy.get('[data-cy="key-person-1__email"]').clear().type(userData[2].email);
 
       cy.get('[data-cy="key-person-1__position"]')
         .clear()
@@ -198,13 +186,9 @@ export const testKeyStatePersonnelWithData = years => {
     cy.findByRole('button', { name: /Add Key Personnel/i }).click();
 
     cy.fixture('users').then(userData => {
-      cy.get('[data-cy="key-person-2__name"]')
-        .clear()
-        .type(userData[3].name);
+      cy.get('[data-cy="key-person-2__name"]').clear().type(userData[3].name);
 
-      cy.get('[data-cy="key-person-2__email"]')
-        .clear()
-        .type(userData[3].email);
+      cy.get('[data-cy="key-person-2__email"]').clear().type(userData[3].email);
 
       cy.get('[data-cy="key-person-2__position"]')
         .clear()

diff --git a/web/src/pages/apd/ApdReadOnly.test.js b/web/src/pages/apd/ApdReadOnly.test.js
@@ -36,8 +36,8 @@ describe('<ApdViewOnly/>', () => {
       },
       initialHistory: ['/apd/1']
     });
-    expect(screen.getByText('HITECH IAPD')).toBeTruthy();
-    expect(screen.getByText('2020-2021 APD')).toBeTruthy();
+    expect(await screen.findByText('HITECH IAPD')).toBeTruthy();
+    expect(await screen.findByText('2020-2021 APD')).toBeTruthy();
 
     await user.click(screen.getByRole('button', { name: '< Back to APD' }));
     expect(history.length).toEqual(1);

diff --git a/web/src/redux/reducers/apd.js b/web/src/redux/reducers/apd.js
@@ -325,7 +325,7 @@ const initialState = {
   loaded: false,
   error: '',
   selectAPDOnLoad: false,
-  adminCheck: process.env.TEALIUM_ENV !== 'prod'
+  adminCheck: false
 };
 
 // eslint-disable-next-line default-param-last

diff --git a/web/src/redux/reducers/apd.test.js b/web/src/redux/reducers/apd.test.js
@@ -35,7 +35,7 @@ describe('APD reducer', () => {
     loaded: false,
     error: '',
     selectAPDOnLoad: false,
-    adminCheck: true
+    adminCheck: false
   };
 
   it('should handle initial state', () => {
@@ -78,7 +78,7 @@ describe('APD reducer', () => {
       loaded: false,
       error: '',
       selectAPDOnLoad: false,
-      adminCheck: true
+      adminCheck: false
     });
   });
 
@@ -90,7 +90,7 @@ describe('APD reducer', () => {
       loaded: false,
       error: '',
       selectAPDOnLoad: false,
-      adminCheck: true
+      adminCheck: false
     });
   });
 
@@ -135,7 +135,7 @@ describe('APD reducer', () => {
       fetching: false,
       loaded: true,
       selectAPDOnLoad: false,
-      adminCheck: true
+      adminCheck: false
     };
 
     expect(
@@ -156,7 +156,7 @@ describe('APD reducer', () => {
       loaded: false,
       error: 'some error',
       selectAPDOnLoad: false,
-      adminCheck: true
+      adminCheck: false
     });
   });