Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty lines at the beginning of a server scope #9

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

arturjpv
Copy link
Member

Developers are having problems if they don't place the ifdef right after the check(System::IsServer()), as the server scope is compared starting after the check and we fail to detect that the server scope is already protected.

	UFUNCTION(BlueprintOverride)
	void Tick(float DeltaSeconds)
	{
		FTraceScope TraceScope(n"UGaitGroundContactHelperComponent::Tick");
		check(System::IsServer());

#ifdef WITH_SERVER
		GroundContactHitResults.Empty();
#endif
	}

Build Discovery.
Build Pioneer.

@arturjpv arturjpv requested a review from tvandijck as a code owner February 10, 2025 15:30
@arturjpv arturjpv merged commit d6573b3 into main Feb 10, 2025
1 check passed
@arturjpv arturjpv deleted the feature/allow-empty-lines branch February 11, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants