Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow trailing comma in parameter list #12

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Allow trailing comma in parameter list #12

merged 2 commits into from
Feb 11, 2025

Conversation

arturjpv
Copy link
Member

Trailing commas were already allowed in enums, but it seems we need to allow them also in parameters lists.

Developers are using this already.

@arturjpv arturjpv requested a review from tvandijck as a code owner February 11, 2025 13:38
@arturjpv arturjpv requested a review from webbju February 11, 2025 13:38
webbju
webbju approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@webbju webbju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm based on initializerClause (Comma initializerClause)* Comma?; // I *really* don't like that trailing commas are a thing in AS... 😄

@arturjpv arturjpv merged commit 89bbc47 into main Feb 11, 2025
1 check passed
@arturjpv arturjpv deleted the feature/trailing-comma-args branch February 11, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbju webbju webbju approved these changes

@tvandijck tvandijck Awaiting requested review from tvandijck tvandijck is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturjpv @webbju