Send CALLERROR only as response to CALL message #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
requested review from
hikinggrass,
maaikez and
marcemmers
as code owners
maaikez
reviewed
Feb 24, 2025
| @@ -1356,6 +1356,9 @@ void ChargePointImpl::message_callback(const std::string& message) { | |||
| } | |||
| } catch (json::exception& e) { | |||
| EVLOG_error << "JSON exception during handling of message: " << e.what(); | |||
| if (enhanced_message.messageTypeId != MessageTypeId::CALL) { | |||
| return; // CALLERROR shall only follow on a CALL message | |||
There was a problem hiding this comment.
Also no security event notification?
maaikez
approved these changes
Feb 24, 2025
…back so that only send CALLERROR on CALL messages Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
…sage cant be handled Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Pietfried
force-pushed
the
feature/do-only-send-callerror-on-call-messages
branch
from
f54a161 to
ee91265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implemented a check of the enhanced_message to handle in message_callback so that only send CALLERROR on CALL messages.
Remark: We may want to restructure out custom exceptions a little better at some point in order to get rid of that repetitive code.
Issue ticket number and link
Checklist before requesting a review