Add forward declarations and move includes to cpp files #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
This was
linked to
issues
Feb 17, 2025
5 tasks
Pietfried
approved these changes
Feb 17, 2025
maaikez
deleted the
feature/chargepoint-use-forward-declarations-for-all-functional-blocks-and-move-includes-of-header-files-to-cpp-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A lot of includes in the functional blocks could be changed to forward declarations and the headers moved to the cpp file. Also, remove some unused headers (messages) that are now part of the functional blocks.
Issue ticket number and link
#974
Checklist before requesting a review