Move provisioning callbacks and handlers to functional block #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaikez
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
|
I am wondering if we want this huge constructor or fix that another way. |
Pietfried
approved these changes
Feb 13, 2025
Comment on lines
181
to
185
| // TODO(piet): B01.FR.06 | ||
| // TODO(piet): B01.FR.07 | ||
| // TODO(piet): B01.FR.08 | ||
| // TODO(piet): B01.FR.09 | ||
| // TODO(piet): B01.FR.13 |
There was a problem hiding this comment.
are now all implemented. B01.FR.13 is missing in the status document, you can add it there as well.
Suggested change
| // TODO(piet): B01.FR.06 | |
| // TODO(piet): B01.FR.07 | |
| // TODO(piet): B01.FR.08 | |
| // TODO(piet): B01.FR.09 | |
| // TODO(piet): B01.FR.13 |
Comment on lines
437
to
440
| // TODO(piet): B11.FR.05 | ||
|
|
||
| // TODO(piet): B12.FR.05 | ||
| // TODO(piet): B12.FR.06 |
There was a problem hiding this comment.
Suggested change
| // TODO(piet): B11.FR.05 | |
| // TODO(piet): B12.FR.05 | |
| // TODO(piet): B12.FR.06 |
all implemented. B11.FR.05 is missing in the status document
maaikez
force-pushed
the
feature/move-transaction-callbacks-and-handlers-to-functional-block
branch
3 times, most recently
from
7165b05 to
6349a4b
Compare
Base automatically changed from
feature/move-transaction-callbacks-and-handlers-to-functional-block
to
main
February 17, 2025 10:40
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…ock. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…plemented. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
force-pushed
the
feature/move-provisioning-callbacks-and-handlers-to-functional-block
branch
from
966376e to
bac1698
Compare
maaikez
deleted the
feature/move-provisioning-callbacks-and-handlers-to-functional-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Provisioning callbacks and handlers to provisioning functional block.
This pull request is based on the pull request to move the transaction functional block, so that must be done first before this one can be merged.
Issue ticket number and link
#975
Checklist before requesting a review