Transaction functional block. #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaikez
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
hikinggrass
reviewed
Feb 11, 2025
Comment on lines
+89
to
+97
| TransactionBlock(MessageDispatcherInterface<MessageType>& message_dispatcher, DeviceModel& device_model, | ||
| ConnectivityManagerInterface& connectivity_manager, EvseManagerInterface& evse_manager, | ||
| MessageQueue<v201::MessageType>& message_queue, DatabaseHandlerInterface& database_handler, | ||
| AuthorizationInterface& authorization, AvailabilityInterface& availability, | ||
| SmartChargingInterface& smart_charging, TariffAndCostInterface& tariff_and_cost, | ||
| StopTransactionCallback stop_transaction_callback, PauseChargingCallback pause_charging_callback, | ||
| std::optional<TransactionEventCallback> transaction_event_callback, | ||
| std::optional<TransactionEventResponseCallback> transaction_event_response_callback, | ||
| ResetCallback reset_callback); |
There was a problem hiding this comment.
For now I think these large ctors (like in the other PRs) are ok, but we should probably try to reduce the number of arguments by grouping (at least) some of the callbacks into a struct
Pietfried
approved these changes
Feb 13, 2025
maaikez
force-pushed
the
feature/move-transaction-callbacks-and-handlers-to-functional-block
branch
from
3353916 to
30ea474
Compare
maaikez
changed the base branch from
feature/temp-combine-functional-blocks
to
main
maaikez
force-pushed
the
feature/move-transaction-callbacks-and-handlers-to-functional-block
branch
from
30ea474 to
7165b05
Compare
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
force-pushed
the
feature/move-transaction-callbacks-and-handlers-to-functional-block
branch
from
7165b05 to
6349a4b
Compare
maaikez
deleted the
feature/move-transaction-callbacks-and-handlers-to-functional-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Move transaction related functions (handlers and callbacks) to transaction functional block.
Note: this pull request will merge to a temporary branch where all previous functional blocks are combined, because those are all in pull request still and otherwise I could not continue. But once they are all merged, I will merge this pull request to main.
Issue ticket number and link
#971
Checklist before requesting a review