Improved handling in case CSMS responds with CALLERROR or not at all to BootNotification.req #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pietfried
commented
Jan 31, 2024
Pietfried
commented
- Added handling for BootNotification.req in case CSMS responds with CALLERROR or no response at all
- BootNotification now has special handling in the message queue so that it will be repeately sent in case of CALLERROR or no message timeout
…ALLERROR or no response at all * BootNotification now has special handling in the message queue so that it will be repeately sent in case of CALLERROR or no message timeout Signed-off-by: pietfried <pietgoempel@gmail.com>
Signed-off-by: pietfried <pietgoempel@gmail.com>
Signed-off-by: pietfried <pietgoempel@gmail.com>
hikinggrass
reviewed
Jan 31, 2024
| @@ -38,6 +38,9 @@ struct MessageQueueConfig { | |||
| bool queue_all_messages; // cf. OCPP 2.0.1. "QueueAllMessages" in OCPPCommCtrlr | |||
|
|
|||
| int message_timeout_seconds = 30; | |||
| int boot_notification_retry_interval_seconds = | |||
| 60; // interval for BootNotification.req in case response by CSMS is CALLERROR or CSMS does not respond at all | |||
There was a problem hiding this comment.
This formatting looks really strange
hikinggrass
approved these changes
Jan 31, 2024
Pietfried
deleted the
bugfix/handle-invalid-bootnotification-conf-by-csms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.