Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for certificate links #398

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Add support for certificate links #398

merged 4 commits into from
Jan 25, 2024

Conversation

mennodegraaf
Copy link
Contributor

  • Add support for certificate links by providing update_certificate_links()

@AssemblyJohn
Copy link
Contributor

@mennodegraaf due to compatibility issues, as a feature that might not be always required, it would be best if we could have this configurable, and work for both ocpp1.6 and ocpp2.0.1. The security lib (with the exception of the GetKeyPair which will be refactored in everest-core) does not have the side-effects which libocpp can have.

@mennodegraaf
Copy link
Contributor Author

@mennodegraaf due to compatibility issues, as a feature that might not be always required, it would be best if we could have this configurable, and work for both ocpp1.6 and ocpp2.0.1. The security lib (with the exception of the GetKeyPair which will be refactored in everest-core) does not have the side-effects which libocpp can have.

This symlink functionality is configurable in the sense that if the symlinks are not configured nothing will be done and the functionality is as it was before.

@AssemblyJohn
Copy link
Contributor

@mennodegraaf due to compatibility issues, as a feature that might not be always required, it would be best if we could have this configurable, and work for both ocpp1.6 and ocpp2.0.1. The security lib (with the exception of the GetKeyPair which will be refactored in everest-core) does not have the side-effects which libocpp can have.

This symlink functionality is configurable in the sense that if the symlinks are not configured nothing will be done and the functionality is as it was before.

I think it would be safer to have the function call to be configurable (if the user wants it or not), especially since it is a niche application, and there can always be side-effect. Except that, I can't find any other issues.

@mennodegraaf
Copy link
Contributor Author

@AssemblyJohn I will it up to you if you want to prevent update_certificate_links() from being called with some config parameter. Note that this method will also make sure that symlinks are removed, e.g. when no certificate is valid anymore. So if symlinks are first created and then it is configured not to call the method anymore and then a certificate expires they will not be deleted.

Menno de Graaf added 3 commits January 24, 2024 12:07
Signed-off-by: Menno de Graaf <m.degraaf@alfen.com>
Signed-off-by: Menno de Graaf <m.degraaf@alfen.com>
Signed-off-by: Menno de Graaf <m.degraaf@alfen.com>
@AssemblyJohn AssemblyJohn force-pushed the mg-josev-symlinks branch 4 times, most recently from b8f4264 to 6e723ed Compare January 25, 2024 08:58
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
@hikinggrass hikinggrass merged commit 84b604a into main Jan 25, 2024
4 checks passed
@hikinggrass hikinggrass deleted the mg-josev-symlinks branch January 25, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants