Move some header files from include/detail subdir to prevent compilation errors in non edm builds #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pilation errors in non edm build envs Signed-off-by: Sebastian Lukas <sebastian.lukas@pionix.de>
SebaLukas
requested review from
a-w50,
MarzellT and
AssemblyJohn
as code owners
Signed-off-by: Sebastian Lukas <sebastian.lukas@pionix.de>
There was a problem hiding this comment.
There is another option, do we really want those headers to include from the 'detail'? For the test case it looks a bit weird to be required during an install. Can't tests be disabled on a target when we are installiing?
However for the other non-test cases, maybe forward declare & use unique pointers? Or that would be bad design?
AssemblyJohn
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Move fsm.hpp & sha_hash.hpp from include/detail subdir to prevent compilation errors in non edm build envs
Issue ticket number and link
#97
Checklist before requesting a review