ServiceDetail messages add EVSide Se/Deserialization #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roger Bedell <rogerbedell@hotmail.com>
Signed-off-by: Roger Bedell <rogerbedell@hotmail.com>
cienporcien
requested review from
a-w50,
SebaLukas,
MarzellT and
AssemblyJohn
as code owners
SebaLukas
approved these changes
Mar 18, 2025
| const auto& in_parameter = in_parameter_set.Parameter.array[t]; | ||
| datatypes::Parameter out_parameter; | ||
|
|
||
| out_parameter.name = std::string(in_parameter.Name.characters, in_parameter.Name.charactersLen); |
There was a problem hiding this comment.
Instead of std::string please use CB2CPP_STRING(). Basically its the same but here we should use the macros from cb_exi.hpp for consistency.
| out_parameter.value = in_parameter.intValue; | ||
| } else if (in_parameter.finiteString_isUsed) { | ||
| out_parameter.value = | ||
| std::string(in_parameter.finiteString.characters, in_parameter.finiteString.charactersLen); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
ServiceDetail messages add EVSide Se/Deserialization and unit tests
Issue ticket number and link
#68
Checklist before requesting a review