Feature/notify ev charging needs #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 6, 2025
AssemblyJohn
force-pushed
the
feature/notify-ev-charging-needs
branch
from
c162938 to
8d369f7
Compare
SebaLukas
requested changes
Mar 11, 2025
SebaLukas
reviewed
Mar 12, 2025
MarzellT
reviewed
Mar 12, 2025
AssemblyJohn
force-pushed
the
feature/notify-ev-charging-needs
branch
from
6e9337d to
5ada88e
Compare
SebaLukas
reviewed
Mar 12, 2025
include/iso15118/detail/d20/state/dc_charge_parameter_discovery.hpp
Outdated
Show resolved
Hide resolved
SebaLukas
reviewed
Mar 12, 2025
SebaLukas
reviewed
Mar 12, 2025
include/iso15118/detail/d20/state/dc_charge_parameter_discovery.hpp
Outdated
Show resolved
Hide resolved
SebaLukas
reviewed
Mar 12, 2025
|
Will wait for: EVerest/everest-core#1062 approval to have a full merge. It will prevent a discontinuity between the everes-core's main and this main. |
I think it's okay if things are merged in the libs even if it breaks everest-core. That's why we have the yaml dependencies, so that everest-core always builds with a compatible lib version. In general, it is also okay if from time to time the main branches of the different repos are not compatible or not buildable. |
AssemblyJohn
force-pushed
the
feature/notify-ev-charging-needs
branch
2 times, most recently
from
7c67bfd to
857192a
Compare
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
…ds all car-provided (EV) data Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
AssemblyJohn
force-pushed
the
feature/notify-ev-charging-needs
branch
from
f61f7af to
24e82cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds the required data collection capabilities and feedback to libiso in order to allow the dispatch of a ChargingNeedsType to any listener that register to the library for information related to EV and EVSE capabilities.
Issue ticket number and link
Related ev-core PR: EVerest/everest-core#1062
Related libocpp PR: EVerest/libocpp#1003Related everest-utils PR: EVerest/everest-utils#180Checklist before requesting a review