Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename v201 to v2 for OCPP modules #1058

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

Pietfried
Copy link
Contributor

@Pietfried Pietfried commented Feb 20, 2025

Describe your changes

This PR addresses the renaming changes in libocpp from v201 to v2 / V201 to V2. All occurances have been renamed according to the changes in libocpp.

Issue ticket number and link

Companion PR in libocpp

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Copy link
Contributor

@maaikez maaikez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Do you want to also change the name of the module? OCPP2 instead of OCPP201?

I am missing python changes though, but I think that's on purpose. So in the python tests we still have ChargePoint201, charge_point_v201, ocpp.v201, call201, call_result201, GenericOCPP201ConfigAdjustment, OCPP201ConfigVariableIdentifier, validate_status_notification_201, TestOcpp201CostAndPrice, etc.
But changes in tests also has effect on everest utils probably.

@Pietfried
Copy link
Contributor Author

Pietfried commented Feb 21, 2025

Looks good.

Do you want to also change the name of the module? OCPP2 instead of OCPP201?

I am missing python changes though, but I think that's on purpose. So in the python tests we still have ChargePoint201, charge_point_v201, ocpp.v201, call201, call_result201, GenericOCPP201ConfigAdjustment, OCPP201ConfigVariableIdentifier, validate_status_notification_201, TestOcpp201CostAndPrice, etc. But changes in tests also has effect on everest utils probably.

Yes those are left out on purpose for now.

I would not rename the module now since this breaks existing configuration. We can discuss this at a later point.

@Pietfried Pietfried marked this pull request as ready for review February 21, 2025 10:46
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…ib/ directories. This change is required because of the changed names in libocpp

Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
@Pietfried Pietfried force-pushed the refactor/rename-ocpp-v201-to-v2 branch from 6c085a4 to 901fde2 Compare February 26, 2025 09:38
@Pietfried Pietfried merged commit 851eac5 into main Feb 26, 2025
11 of 12 checks passed
@Pietfried Pietfried deleted the refactor/rename-ocpp-v201-to-v2 branch February 26, 2025 12:51
wku12 pushed a commit to wku12/everest-core that referenced this pull request Mar 4, 2025
* Renamed all occuranced of v201 to v2 and V201 to V2 in modules/ and lib/ directories. This change is required because of the changed names in libocpp

Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>

---------

Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants