-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename v201 to v2 for OCPP modules #1058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Do you want to also change the name of the module? OCPP2 instead of OCPP201?
I am missing python changes though, but I think that's on purpose. So in the python tests we still have ChargePoint201, charge_point_v201, ocpp.v201, call201, call_result201, GenericOCPP201ConfigAdjustment, OCPP201ConfigVariableIdentifier, validate_status_notification_201, TestOcpp201CostAndPrice, etc.
But changes in tests also has effect on everest utils probably.
Yes those are left out on purpose for now. I would not rename the module now since this breaks existing configuration. We can discuss this at a later point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…ib/ directories. This change is required because of the changed names in libocpp Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
6c085a4
to
901fde2
Compare
* Renamed all occuranced of v201 to v2 and V201 to V2 in modules/ and lib/ directories. This change is required because of the changed names in libocpp Signed-off-by: Piet Gömpel <pietgoempel@gmail.com> --------- Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Describe your changes
This PR addresses the renaming changes in libocpp from v201 to v2 / V201 to V2. All occurances have been renamed according to the changes in libocpp.
Issue ticket number and link
Companion PR in libocpp
Checklist before requesting a review