Add Villasenor and Buneman current deposition with explicit scheme #5700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good Dave. Have you tried running with explicit yet? There is a WARPX_ALWAYS_ASSERT_WITH_MESSAGE in WarpX.cpp that prevents using Villasenor with explicit. That can be removed. |
|
We should also update the docs to reflect this PR. |
There was a problem hiding this comment.
Need a minor update here on line 2257 as well to reflect villasenor option below.
JustinRayAngus
approved these changes
Feb 27, 2025
|
@ax3l You requested a self-review. Did you still want to review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Villasenor and Buneman current deposition was moved to a separate kernel routine and added implicit and explicit callers.
A test case is a 2D uniform plasma, run for a number of plasma periods. The images below show the relative change in the energgy for the parts of the system. The total energy is conversed to roughly 1.e-5. The results are shown for both the Villasenor and the Esirkepov current deposition. The results are essentially the same, with the differences in the two cases below the resolution of the images.
