Added support to use adios2's flatten_step #5634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable it, put it in the openPMD option through input file.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ax3l
added
component: openPMD
lucafedeli88
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Thanks for this PR, @guj !
I've left few comments, mainly to make clang-tidy and CodeQL happy.
Added braces for the if/else loop via Luca Fedeli Co-authored-by: Luca Fedeli <luca.fedeli.88@gmail.com>
added const to bool variable via Luca Fedeli Co-authored-by: Luca Fedeli <luca.fedeli.88@gmail.com>
eliminate extra space Co-authored-by: Luca Fedeli <luca.fedeli.88@gmail.com>
remove commented line via Luca Fedeli Co-authored-by: Luca Fedeli <luca.fedeli.88@gmail.com>
Remove commented line via Luca Fedeli Co-authored-by: Luca Fedeli <luca.fedeli.88@gmail.com>
typo spotted by Luca Fedeli Co-authored-by: Luca Fedeli <luca.fedeli.88@gmail.com>
ax3l
reviewed
Mar 3, 2025
ax3l
reviewed
Mar 3, 2025
ax3l
reviewed
Mar 3, 2025
ax3l
reviewed
Mar 3, 2025
ax3l
reviewed
Mar 3, 2025
ax3l
reviewed
Mar 3, 2025
`buffer` target would not work in BTD if not used with `flattenSteps`: final flush would be missing at the end of the current snapshot write to the stations.
ax3l
added
bug
ax3l
reviewed
Mar 3, 2025
| .. code-block:: text | ||
|
|
||
| <diag_name>.openpmd_backend = bp5 | ||
| <diag_name>.adios2_engine.parameters.FlattenSteps = on |
There was a problem hiding this comment.
@guj does this only have an effect for variable based encoding or generally (e.g., file based encoding)?
There was a problem hiding this comment.
but right now flatten steps is only applied to BTD
ax3l
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Opt-In Feature for BTD
To enable it, put it in the openPMD option through input file:
e.g.
This feature is useful for BTD use case. Data can be flushed after each buffered writes of a snapshot
To check weather this feature is in use, try "bpls -V your_bp_file_name"
Note: we still debug performance regressions in writing when
FlattenStepsis used. This will be addressed in follow-up updates to ADIOS2/openPMD-api.Bug Fix
Also fixes openPMD/openPMD-api#1655 for BP5 with file-based encoding, i.e., when some ranks have no particles to contribute to a step.