Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove federated types when rendering SDL #42

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Remove federated types when rendering SDL #42

merged 1 commit into from
Mar 31, 2022

Conversation

kdawgwilk
Copy link
Collaborator

@kdawgwilk kdawgwilk commented Mar 31, 2022 •
edited
Loading

Fixes the issue with absinthe eagerly removing the types but still strips out the federated types

Closes #21

@kdawgwilk kdawgwilk added the bug Something isn't working label Mar 31, 2022
@kdawgwilk kdawgwilk added this to the v1.0 milestone Mar 31, 2022
@kdawgwilk kdawgwilk requested a review from kzlsakal March 31, 2022 06:17
@kdawgwilk kdawgwilk self-assigned this Mar 31, 2022
@kdawgwilk kdawgwilk merged commit b35776e into main Mar 31, 2022
@kdawgwilk kdawgwilk deleted the kaden/remove_federated_types_sdl branch March 31, 2022 15:58
kzlsakal added a commit that referenced this pull request Apr 6, 2022
@kzlsakal
Revert "Remove federated types when rendering SDL (#42)"
f906bf3 
This reverts commit b35776e.
@kzlsakal kzlsakal mentioned this pull request Apr 6, 2022
Merged
kzlsakal added a commit that referenced this pull request Apr 6, 2022
@kzlsakal
Revert remove_federated_types and add tests for types extended types (#…
5d29537 
…48)

* Revert "Remove federated types when rendering SDL (#42)"

This reverts commit b35776e.

* Add tests to ensure extended types are included in the SDL
@kzlsakal kzlsakal mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzlsakal kzlsakal kzlsakal approved these changes

Assignees

@kdawgwilk kdawgwilk

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Fix _service { sdl } render to hide federated fields
2 participants
@kdawgwilk @kzlsakal