Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers outside margin #60

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

pmudry
Copy link

@pmudry pmudry commented Jan 13, 2025

A first implementation in the direction of #53

Two shortcomings with the current implementation :

  • radius is not implemented as only the whole block can have a radius and not the grid element themselves. I don't see any elegant solution to solve this currently.
  • when skipping line numbers, the width is not completely taken into account. The logic behind the skipping is not 100% clear to me.

@Dherse
Copy link
Owner

Dherse commented Jan 13, 2025

I don't have time to do a full review (yet) since I'm working, but I see two main pointer:

  • There's a bash file for running tests which is not needed, and must be removed, I use typst-test by tinger
  • There's a lib_back.typ which you have to remove too, we use git to avoid needing backups :D

Otherwise, it looks good from the quick look I've had it looks good and simpler than I expected, I'll play around with it as soon as I have time for it. Thanks a lot for your work!

@pmudry
Copy link
Author

pmudry commented Jan 13, 2025

I don't have time to do a full review (yet) since I'm working, but I see two main pointer:

* There's a bash file for running tests which is not needed, and must be removed, I use `typst-test` by tinger

I had no clue something such as typst-test existed, it's really nice! I integrated a new test for the new numbers-outside-margin option.

* There's a `lib_back.typ` which you have to remove too, we use git to avoid needing backups :D

Sorry for dangling backup file. It has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants