Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the app name #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Karan-29
Copy link

@Karan-29 Karan-29 commented Mar 6, 2021

Fixes issue #17
If there is something else i could add, to improve my code. Please suggest.

@Karan-29 Karan-29 closed this Mar 6, 2021
@Karan-29 Karan-29 reopened this Mar 6, 2021
@DhairyaBahl DhairyaBahl self-requested a review March 6, 2021 10:17
Copy link
Owner

@DhairyaBahl DhairyaBahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to make few changes

  1. Howzapp Seems to be good but give me atleast 5 options from which I can choose if that's okay with You. After our mutual discussion, you can then make the PR.

  2. Add yourself in the contributors.md file.

  3. after doing the required tasks do squash your commits again.

@Karan-29
Copy link
Author

Karan-29 commented Mar 6, 2021

Okay. I just had a doubt. How do i squash all my commits.
Thanks

@DhairyaBahl
Copy link
Owner

@Karan-29 To squash all your commits, you have to use this command :

git rebase -i HEAD~5

After this, some editor will open and there you will have to rename the details from pick to squash and then you can save those and voila you are done !

For more information, refer this

Copy link
Owner

@DhairyaBahl DhairyaBahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some pictures of how the app is looking now ? and secondly we don't make any changes in the index.html file so kindly revert back those changes.

@Karan-29
Copy link
Author

Karan-29 commented Mar 8, 2021

This is how the app looks now
Screenshot (22)
Screenshot (23)

@dilemmawalker
Copy link
Collaborator

@Karan-29 first pull the changes then push them to resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants