-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamburger menu for responsive navbar #41
Conversation
@miralsuthar is attempting to deploy a commit to the Developerdao Team on Vercel. A member of the Team first needs to authorize it. |
@angeljgomezc just put PR for issue #10 for adding the hamburger menu in the navbar for mobile responsiveness. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/developdao/dao-job-board/5fGcXb6HPkfaFYJWn8ZCNQqGu5R4 [Deployment for 6012bdf failed] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple pieces of feedback for you!
Also this project recently switched from npm
to yarn
, so you'll want to delete client/package-lock.json
and run yarn
to install packages instead.
@with-heart fixed Miral's PR to avoid conflicts with my last PR. Check this whenever you can and preview the Navbar. THANK YOU! |
Finished the last few touches for the hamburger menu to be ready for deployment in the main branch. @with-heart would love your feedback on this component |
Co-authored-by: with-heart <with.heart+git@pm.me>
What does it do?
Add hamburger menu navbar for mobile view
Does it close any issue?
it closes issue #10