This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
battery remaining extension causes conflicts with other extensions #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utton() were being called prior to calling this, which made Main.panel.statusArea['batteryBox'] undefined. * Adding a check to hideButton() and showButton() to make sure Main.panel.statusArea['batteryBox'] isn't undefined prior to checking the rightBox item's _deligate attribute (which very well could be undefined)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that this extension is conflicting with the GPaste extension, and possibly others. See the following bug from GPaste Keruspe/GPaste#51
After investigating, I found that if the batteryBox has not been created when hideBattery() or showBattery() is called, matching Main.panel.statusArea['batteryBox'] to Main.panel._rightBox.get_children()[i]._delegate will succeed for every extension. I've moved the call to the _replaceIconWithBox() call to come before the hideBattery() and showBattery() calls. I've also added a check to each of those functions to ensure that Main.panel.statusArea['batteryBox'] is not undefined before comparing to the _delegate property.