Gyroscope: fee adapter #2465
Open
Gyroscope: fee adapter #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The gyroscope adapter exports: |
dtmkeng
requested changes
Feb 26, 2025
fees/gyroscope/index.ts
Outdated
| return async (options: FetchOptions) => { | ||
| const dailyFees = options.createBalances(); | ||
| try { | ||
| const value = await queryDune("4776022", {}); |
There was a problem hiding this comment.
seem your query is wrong
- should split by chain
There was a problem hiding this comment.
also, can you compute this on chain using event logs, the dune query is bit confusing
|
The gyroscope adapter exports: |
Lor3mipsvm
commented
Feb 28, 2025
There was a problem hiding this comment.
- tried to add a fee split by chain
- doing this with onchain events would be rather convoluted, dune seems significantly easier
- would strongly welcome any edits to make this adapter work
There was a problem hiding this comment.
"doing this with onchain events would be rather convoluted" why? can you briefly explain how you are computing the fees? I can look into writing the adapter myself.
We prefer onchain adapter over dune as it is less maintenance and we have better control
There was a problem hiding this comment.
would be amazing if you could help with the adapter @g1nt0ki .
here would be the logic for doing this onchain:
- protocol fees accrue from pools to fee collector addresses. fee collector addresses are defined on a per-chain basis.
- listing these addresses below, but FYI, you can query the fee collector addresses by looking at the addresses returned by the
getFeesMetadatafunction of any pool: eg https://basescan.org/address/0x276a02120c71193b138941dc5838da270e98e088#readContract#F11 - fees that accrue to the fee collector addresses are LP shares and must be priced first. the LP share pricing logic is as follows:
(amount of LP shares minted to the fee collector) / (post-event pool.getActualSupply()) * (post-event pool TVL)
for your convenience, also listing all fee collector addresses here:
- https://basescan.org/address/0xce88686553686DA562CE7Cea497CE749DA109f9F
- https://basescan.org/address/0xA01ba17778A860EC92053325d0de4022240ceeA4
- https://etherscan.io/address/0xA01ba17778A860EC92053325d0de4022240ceeA4
- https://etherscan.io/address/0xce88686553686DA562CE7Cea497CE749DA109f9F
- https://gnosisscan.io/address/0xce88686553686DA562CE7Cea497CE749DA109f9F
- https://polygonscan.com/address/0xce88686553686DA562CE7Cea497CE749DA109f9F
- https://seitrace.com/address/0xDcC628c4C9f3840EA70f95798Ec4C16B0DA23ef9?chain=pacific-1
- https://snowtrace.io/address/0xA01ba17778A860EC92053325d0de4022240ceeA4
- https://snowtrace.io/address/0xce88686553686DA562CE7Cea497CE749DA109f9F
- https://arbiscan.io/address/0xce88686553686DA562CE7Cea497CE749DA109f9F
- https://arbiscan.io/address/0xA01ba17778A860EC92053325d0de4022240ceeA4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.