Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tvl adapter for sailfish to use uniV3GraphExport #13443

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

olulofe
Copy link
Contributor

@olulofe olulofe commented Feb 10, 2025

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.


  • If you would like to add a volume adapter please submit the PR here.
  • If you would like to add a liquidations adapter, please refer to this readme document for details.
  1. Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
  2. Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
  3. Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
  4. For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data2.ts, you can edit it there and put up a PR
  5. Do not edit/push package-lock.json file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CI
  6. No need to go to our discord and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):

@waynebruce0x
Copy link
Collaborator

Hey could you check the branch conflicts before we run CI? Thanks

@waynebruce0x waynebruce0x self-assigned this Feb 10, 2025
@llamabutler
Copy link

The adapter at projects/sailfish-v3 exports TVL:

occ                       105.79 k

total                    105.79 k 

Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any issue with current implementation?

@olulofe
Copy link
Contributor Author

olulofe commented Feb 10, 2025

any issue with current implementation?

It's reporting less TVL
Screenshot 2025-02-10 at 8 03 43 pm

The subgraph reports the up-to-date TVL. I am guesssing issue stems from no price Oracle for USDC, USDT and other tokens on EDUCHAIN.
Screenshot 2025-02-10 at 8 04 09 pm

@olulofe
Copy link
Contributor Author

olulofe commented Feb 11, 2025

any issue with current implementation?

Bumping this up

@waynebruce0x
Copy link
Collaborator

we are missing prices for USDC, USDT, WISER, ESD. We can add support for USDC, USDT pricing. Do you know how we could price WISER, ESD? Are these native to educhain?

@olulofe
Copy link
Contributor Author

olulofe commented Feb 12, 2025

we are missing prices for USDC, USDT, WISER, ESD. We can add support for USDC, USDT pricing. Do you know how we could price WISER, ESD? Are these native to educhain?

Yes, they are currently native to EDU Chain atm. ESD is 1 : 1 USDC though, more like an LSD also

@olulofe
Copy link
Contributor Author

olulofe commented Feb 16, 2025

we are missing prices for USDC, USDT, WISER, ESD. We can add support for USDC, USDT pricing. Do you know how we could price WISER, ESD? Are these native to educhain?

Yes, they are currently native to EDU Chain atm. ESD is 1 : 1 USDC though, more like an LSD also

Bumping this up @waynebruce0x

@waynebruce0x
Copy link
Collaborator

So we should just peg ESD to 1 USDC? Are there any contract functions to fetch the tokens rate? How about WISER? Should we merge this with only USDC, USDT support?

@llamabutler
Copy link

The adapter at projects/sailfish-v3 exports TVL:

occ                       218.04 k

total                    218.04 k 

@olulofe
Copy link
Contributor Author

olulofe commented Mar 3, 2025

So we should just peg ESD to 1 USDC? Are there any contract functions to fetch the tokens rate? How about WISER? Should we merge this with only USDC, USDT support?

Yes, pegg it USDC. Also USDT and USDC should also factor in the TVL. It currently doesnt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants