CORE-69: update to latest github actions; action cleanup #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
davidangb
commented
Feb 10, 2025
| ~/.gradle/wrapper | ||
| key: v1-${{ runner.os }}-gradle-${{ hashfiles('**/gradle-wrapper.properties') }}-${{ hashFiles('**/*.gradle') }} | ||
| restore-keys: v1-${{ runner.os }}-gradle-${{ hashfiles('**/gradle-wrapper.properties') }} | ||
| cache: 'gradle' |
There was a problem hiding this comment.
setup-java now has built-in caching for gradle; use that instead of managing our own via actions/cache@v3
davidangb
commented
Feb 10, 2025
| with: | ||
| version: '411.0.0' |
There was a problem hiding this comment.
google-github-actions/auth does not accept a version input. Perhaps this got mixed up with the setup-gcloud call just below it? Regardless, this input did nothing other than give a red squiggly in IntelliJ.
davidangb
requested review from
a team,
kevinpalis and
dvoet
and removed request for
a team
dvoet
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup-java's cache for gradle instead of an explicit call toactions/cachegoogle-github-actions/auth