[ID-1051] Add GitHub account linking #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
samanehsan
changed the title
tlangs
suggested changes
Feb 13, 2024
| } | ||
|
|
||
| public Optional<LinkedAccount> createLink( | ||
| String providerName, |
There was a problem hiding this comment.
This should be a Provider, not a String. That way, we can do validation on it.
There was a problem hiding this comment.
I'll change it to be consistent with #168. I'm not sure that we need to check if this is a valid provider here since that already happens upstream. Unless you mean validating that it is a token-based provider?
| @@ -76,6 +80,7 @@ public ResponseEntity<LinkInfo> createLink( | |||
| .userId(samUser.getSubjectId()) | |||
| .clientIP(request.getRemoteAddr()); | |||
|
|
|||
| Optional<LinkInfo> linkInfo; | |||
| try { | |||
| if (providerName.equals(Provider.RAS)) { | |||
There was a problem hiding this comment.
Since providerName is an enum value, we can replace this if/else with a switch statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira:
What:
Add
githubas a provider option for the following endpoints:/api/oidc/v1/{provider}/api/oidc/v1/{provider}/api/oidc/v1/{provider}/authorization-url/api/oidc/v1/{provider}/oauthcodeThe only endpoint changed in this PR is the POST endpoint. If the provider is
github, the createLink method for token providers will be called (not passport providers).Why:
This PR enables a user to link their github account, which will allow them to import private workflows into their Terra workspace.
How:
TokenProviderServicewith acreateLinkmethod that handles account linking for any provider that uses access tokens.Note: This is blocked by https://broadworkbench.atlassian.net/browse/ID-1044 (adding github to the ECM provider configuration)