Skip to content

Commit

Permalink
CORE-69: update com.google.cloud:spring-cloud-gcp-starter-logging fro…
Browse files Browse the repository at this point in the history
…m 4.9.0 to 6.0.0 (#248)

* [CORE-69]: Bump com.google.cloud:spring-cloud-gcp-starter-logging

Bumps [com.google.cloud:spring-cloud-gcp-starter-logging](https://github.com/GoogleCloudPlatform/spring-cloud-gcp) from 4.9.0 to 6.0.0.
- [Release notes](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/releases)
- [Changelog](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/main/CHANGELOG.md)
- [Commits](GoogleCloudPlatform/spring-cloud-gcp@v4.9.0...v6.0.0)

---
updated-dependencies:
- dependency-name: com.google.cloud:spring-cloud-gcp-starter-logging
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* scan verifyPacts

* disable google java client secret manager

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marc Talbott <mtalbott@broadinstitute.org>
  • Loading branch information
3 people authored Mar 3, 2025
1 parent 9692d5b commit 96dd256
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/verify_consumer_pacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ jobs:
echo "env.PROVIDER_BRANCH=${{ env.PROVIDER_BRANCH }} # This reflects the provider branch to switch to for pact verification"
echo "env.CONSUMER_VERSION=${{ env.CONSUMER_VERSION }} # This reflects the consumer version for pact verification (generated by Pact Broker)"
echo "env.PROVIDER_VERSION=${{ env.PROVIDER_VERSION }} # Deprecate env.PACT_PROVIDER_COMMIT. This new envvar is used for migrating GIT hash to app versioning"
./gradlew --build-cache verifyPacts
./gradlew --build-cache verifyPacts --scan
can-i-deploy: # The can-i-deploy job will run as a result of a PR. It reports the pact verification statuses on all deployed environments.
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion service/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ dependencies {
implementation platform('com.google.cloud:libraries-bom:26.55.0')
implementation 'com.google.cloud:google-cloud-pubsub'
implementation 'com.google.cloud:google-cloud-datastore'
implementation 'com.google.cloud:spring-cloud-gcp-starter-logging:4.9.0'
implementation 'com.google.cloud:spring-cloud-gcp-starter-logging:6.0.0'

annotationProcessor 'org.immutables:value:2.10.1'
implementation('bio.terra:terra-common-lib:1.1.35-SNAPSHOT') {
Expand Down
5 changes: 5 additions & 0 deletions service/src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ spring:
application.name: externalcreds
application.version: ${externalcreds.version.gitHash:unknown}

cloud:
gcp:
secretmanager:
enabled: false

config.import: classpath:providers.yml,optional:classpath:rendered/version.properties;optional:classpath:rendered/allowed_jwks.yaml;optional:classpath:rendered/allowed_jwt_issuers.yaml

datasource:
Expand Down

0 comments on commit 96dd256

Please sign in to comment.