Remove parent id in HierarchyHasParentFilterTranslator (#1184)

* Remove parent id in HierarchyHasParentFilterTranslator * Update SQL * Update SQL --------- Co-authored-by: github-actions <github-actions@github.com>
DataBiosphere · Mar 3, 2025 · ae8ea12 · ae8ea12
1 parent 614e476
commit ae8ea12
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/.../terra/tanagra/query/bigquery/translator/filter/BQHierarchyHasParentFilterTranslator.java b/.../terra/tanagra/query/bigquery/translator/filter/BQHierarchyHasParentFilterTranslator.java
@@ -81,8 +81,7 @@ public String buildSql(SqlParams sqlParams, String tableAlias) {
         parentIdFilterSql,
         null,
         false,
-        sqlParams,
-        parentIds.toArray(new Literal[0]));
+        sqlParams);
   }
 
   @Override

diff --git a/underlay/src/test/resources/sql/BQHierarchyFilterTest/hierarchyHasParentFilterEquals.sql b/underlay/src/test/resources/sql/BQHierarchyFilterTest/hierarchyHasParentFilterEquals.sql
@@ -9,7 +9,4 @@
         FROM
             ${HCP_condition_default}          
         WHERE
-            parent = @val0          
-        UNION
-        ALL SELECT
-            @val1)
+            parent = @val0)
diff --git a/underlay/src/test/resources/sql/BQHierarchyFilterTest/hierarchyHasParentFilterIn.sql b/underlay/src/test/resources/sql/BQHierarchyFilterTest/hierarchyHasParentFilterIn.sql
@@ -9,10 +9,4 @@
         FROM
             ${HCP_condition_default}          
         WHERE
-            parent IN (@val0, @val1)          
-        UNION
-        ALL SELECT
-            @val2          
-        UNION
-        ALL SELECT
-            @val3)
+            parent IN (@val0, @val1))