[WOR-1544] Populate MDC for flight and its steps #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap flight thread execution so that flight threads are context-aware. Logs emitted during a flight thread now have the context from the calling thread, along with flight-specific context (flight ID and class). Logs emitted during the execution of a step additionally include step-specific context (step class, direction, and index). Handles the case where a flight thread spawns a child flight by intentionally cleaning any leftover step-specific context from the calling thread. Drive-by: now that we include flight ID and class on all flight logs in the MDC, we can trim down the dismal failure log line.
We cannot call MDC.setContextMap with a null input.
okotsopoulos
commented
Feb 28, 2024
| flightContext.getFlightClassName(), | ||
| flightContext.getStepIndex(), | ||
| flightContext.getStepClassName()); | ||
| "{} (index {}) experienced DISMAL FAILURE: non-retryable error on undo", |
There was a problem hiding this comment.
Drive-by: now that we include flight ID and class on all flight logs in the MDC, we can trim down the dismal failure log line.
I also reformatted to lead with the failing step class based off of Stairway retro feedback that all of the useful information on a log line is at the end. Do we like this better? Unfortunately we don't get step context in MDC for free at this point -- we're outside of step execution.
okotsopoulos
changed the title
|
|
Got into a weird Git state, recreating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/WOR-1544
Wrap flight thread execution so that flight threads are context-aware.
Handles the case where a flight thread spawns a child flight by intentionally cleaning any leftover step-specific context from the calling thread.