CORE-308 expand concurrent requests to sam #4830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoet
commented
Feb 27, 2025
| .dispatcher(dispatcher) | ||
| .build() | ||
| } | ||
|
|
||
| private def getApiClient(token: String)(implicit ev: Ask[F, AppContext]): F[ApiClient] = | ||
| for { | ||
| ctx <- ev.ask | ||
| okHttpClientBuilder = okHttpClient.newBuilder |
There was a problem hiding this comment.
I left the builder here because the following todo is still relevant
dvoet
commented
Feb 27, 2025
Comment on lines
+36
to
+37
| dispatcher.setMaxRequests(maxConcurrentRequests) | ||
| dispatcher.setMaxRequestsPerHost(maxConcurrentRequests) |
There was a problem hiding this comment.
this client is only handling a single host so these are both set to the same value
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4830 +/- ##
===========================================
- Coverage 74.59% 74.58% -0.01%
===========================================
Files 166 166
Lines 14609 14612 +3
Branches 1101 1172 +71
===========================================
+ Hits 10898 10899 +1
- Misses 3711 3713 +2
Continue to review full report in Codecov by Sentry.
|
lucymcnatt
approved these changes
Feb 27, 2025
LizBaldo
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/CORE-308
Summary of changes
This PR increases the number of concurrent requests a Leo instance can make to Sam from 5 (the default) to 15. This is an attempt to address socket timeout errors that appear in the logs (but are retries, presumably successfully).
What
Why
Testing these changes
What to test
Who tested and where
jenkins retestorjenkins multi-test.