Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[CORE-182] Move listRuntimes over to new Sam permissions model (#4810)" #4823

Merged
merged 2 commits into from
Jan 17, 2025

scalafmt

2ebeac7
Select commit
Loading
Failed to load commit list.
Merged

Revert "[CORE-182] Move listRuntimes over to new Sam permissions model (#4810)" #4823

scalafmt
2ebeac7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

74.77% (target 70.00%)

View this Pull Request on Codecov

74.77% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 95.08197% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.77%. Comparing base (3fd8cc2) to head (2ebeac7).

Files with missing lines Patch % Lines
...orkbench/leonardo/db/RuntimeServiceDbQueries.scala 93.02% 3 Missing ⚠️
...h/leonardo/http/service/RuntimeServiceInterp.scala 88.88% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4823      +/-   ##
===========================================
+ Coverage    74.62%   74.77%   +0.15%     
===========================================
  Files          166      166              
  Lines        14690    14800     +110     
  Branches      1158     1112      -46     
===========================================
+ Hits         10962    11067     +105     
- Misses        3728     3733       +5     
Files with missing lines Coverage Δ
...rkbench/leonardo/http/AppDependenciesBuilder.scala 97.88% <100.00%> (+0.01%) ⬆️
...leonardo/http/service/RuntimeV2ServiceInterp.scala 96.12% <100.00%> (+0.67%) ⬆️
...orkbench/leonardo/db/RuntimeServiceDbQueries.scala 96.31% <93.02%> (-0.38%) ⬇️
...h/leonardo/http/service/RuntimeServiceInterp.scala 91.54% <88.88%> (-0.20%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd8cc2...2ebeac7. Read the comment docs.