Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-182] Convert remaining runtime operations to new Sam permissions model #4820

Merged
merged 12 commits into from
Jan 10, 2025

Merge branch 'develop' into mtalbott-runtimes

5702f8c
Select commit
Loading
Failed to load commit list.
Merged

[CORE-182] Convert remaining runtime operations to new Sam permissions model #4820

Merge branch 'develop' into mtalbott-runtimes
5702f8c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 1s

74.62% (target 70.00%)

View this Pull Request on Codecov

74.62% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (59aaba2) to head (5702f8c).

Files with missing lines Patch % Lines
...dinstitute/dsde/workbench/leonardo/samModels.scala 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4820      +/-   ##
===========================================
- Coverage    74.63%   74.62%   -0.01%     
===========================================
  Files          165      166       +1     
  Lines        14850    14692     -158     
  Branches      1187     1135      -52     
===========================================
- Hits         11083    10964     -119     
+ Misses        3767     3728      -39     
Files with missing lines Coverage Δ
...ute/dsde/workbench/leonardo/dao/sam/SamUtils.scala 100.00% <100.00%> (ø)
...rkbench/leonardo/http/AppDependenciesBuilder.scala 97.87% <ø> (-0.02%) ⬇️
...rkbench/leonardo/http/GcpDependenciesBuilder.scala 73.44% <ø> (ø)
...workbench/leonardo/http/service/ProxyService.scala 73.42% <100.00%> (-0.57%) ⬇️
...h/leonardo/http/service/RuntimeServiceInterp.scala 91.73% <100.00%> (+3.17%) ⬆️
...leonardo/http/service/RuntimeV2ServiceInterp.scala 95.45% <100.00%> (+3.22%) ⬆️
...dinstitute/dsde/workbench/leonardo/samModels.scala 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59aaba2...5702f8c. Read the comment docs.