[AN-256] Update mysql version to 8.0 for unit test and local leo #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizBaldo
commented
Nov 21, 2024
| @@ -37,7 +37,7 @@ mysql { | |||
| port = 3311 | |||
| db { | |||
| driver = "com.mysql.cj.jdbc.Driver" | |||
| url = "jdbc:mysql://"${mysql.host}":"${mysql.port}"/leotestdb?createDatabaseIfNotExist=true&useSSL=false&rewriteBatchedStatements=true&nullNamePatternMatchesAll=true" | |||
| url = "jdbc:mysql://"${mysql.host}":"${mysql.port}"/leotestdb?createDatabaseIfNotExist=true&&allowPublicKeyRetrieval=true&useSSL=false&rewriteBatchedStatements=true&nullNamePatternMatchesAll=true" | |||
There was a problem hiding this comment.
Needed now with 8.0, see https://customerportal.qlik.com/article/MySQL-JDBC-connection-Public-Key-Retrieval-is-not-allowed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4802 +/- ##
========================================
Coverage 74.79% 74.79%
========================================
Files 165 165
Lines 14951 14951
Branches 1187 1187
========================================
Hits 11182 11182
Misses 3769 3769 Continue to review full report in Codecov by Sentry.
|
|
@lucymcnatt it looks like the liquibase and url changes are backward compatible with 5.6 🎉 So I am going to revert my commit back to 8.0 and this is ready for a final review. |
lucymcnatt
approved these changes
Nov 22, 2024
jgainerdewar
approved these changes
Nov 22, 2024
This was referenced Nov 25, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/AN-256
Summary of changes
What
Why
Testing these changes
What to test
Who tested and where
jenkins retestorjenkins multi-test.