Enable v1 APIs for Disk, App, and Runtime for Azure hosted Leonardo instances #4737
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4737 +/- ##
===========================================
+ Coverage 73.90% 73.94% +0.03%
===========================================
Files 161 161
Lines 15054 15077 +23
Branches 1222 1234 +12
===========================================
+ Hits 11125 11148 +23
Misses 3929 3929
Continue to review full report in Codecov by Sentry.
|
| @@ -122,10 +122,10 @@ class DiskServiceInterp[F[_]: Parallel](config: PersistentDiskConfig, | |||
| ): F[Unit] = | |||
| for { | |||
| ctx <- as.ask | |||
| sourceAncestry <- F.fromFuture(F.delay(googleProjectDAO.getAncestry(sourceGoogleProject.value))) | |||
| sourceAncestry <- F.fromFuture(F.delay(googleProjectDAO.get.getAncestry(sourceGoogleProject.value))) | |||
There was a problem hiding this comment.
My concern with sprinkling .get in this code is that the API will fail with a HTTP 500 scala.MatchError if these APIs are called in a Leo deployment with no GCP dependencies.
A cleaner option might be doing something like this in the appropriate endpoints (e.g. create/delete runtime/disk):
projectDAO <- F.fromOption(googleProjectDAO, BadRequestException("GCP is not enabled"))
// then use projectDAO as needed
Then you would get a sensible error message and HTTP status code if a GCP-specific API is called.
(I realize that this only affects the VA deployment and v1 create/delete runtime/disk will never actually be called. So just a minor suggestion.)
Jira ticket: https://broadworkbench.atlassian.net/browse/TOAZ-366
Summary of changes
Enable v1 APIs for Disk, App, and Runtime for Azure hosted Leonardo instances.
What
Why
v1 APIs are still used in TerraUI for data retrieval even when hosted on Azure. This will be changed with ongoing development of platform agnostic v2 APIs
This change is covered by automated tests
jenkins retestorjenkins multi-test.I validated this change
Primary reviewer validated this change
I validated this change in the dev environment