Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-4825] Get drshub url from helm, not hardcoded reference.conf #4201

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

LizBaldo
Copy link
Collaborator

@LizBaldo LizBaldo commented Feb 9, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/IA-4825

Summary of changes

What

  • Make sure that the drs url is pulled from leonardo helm values to leo.conf and not what is hardcoded in reference.conf

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

Copy link
Collaborator

@rtitle rtitle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I validated we are setting that EV in helmfile: https://github.com/broadinstitute/terra-helmfile/blob/master/values/app/leonardo/live/prod.yaml#L75

Though it looks like it's still on martha, not drshhub 🤔

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86c1f77) 71.20% compared to head (002221a) 71.19%.
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4201      +/-   ##
===========================================
- Coverage    71.20%   71.19%   -0.02%     
===========================================
  Files          147      147              
  Lines        13966    13966              
  Branches      1123     1123              
===========================================
- Hits          9945     9943       -2     
- Misses        4021     4023       +2     
Flag Coverage Δ
pact 48.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22eb6b0...002221a. Read the comment docs.

@LizBaldo LizBaldo marked this pull request as ready for review February 9, 2024 19:04
@LizBaldo
Copy link
Collaborator Author

LizBaldo commented Feb 9, 2024

Testing on my BEE and the new URLs are up now 👍

@LizBaldo LizBaldo merged commit b21eded into develop Feb 9, 2024
22 of 23 checks passed
@LizBaldo LizBaldo deleted the IA-4825-correct-drshub-url branch February 9, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants