[IA-4821] Add branch name to leo release tag

[LizBaldo]

Jira ticket: https://broadworkbench.atlassian.net/browse/IA-4821

Summary of changes

What

Appends the build branch to the image release tag to make it more easily searchable on GCR

Why

The move from jenkins to GHA removed the ability to tag the docker image with multiple tags, including the branch name that was very useful for developers when updating their BEEs. The leonardo build GHA unfortunately only takes in one tag as an input so we could do:

• This PR that simply appends the name of the branch to the version (pending the syntax is correct)
• Modify the leonardo build GHA to add another tag to the docker image using the build branch name

Testing these changes

What to test

Who tested and where

• This change is covered by automated tests
  • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
• I validated this change
• Primary reviewer validated this change
• I validated this change in the dev environment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3e5df7) 71.32% compared to head (25cabf5) 71.37%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4185      +/-   ##
===========================================
+ Coverage    71.32%   71.37%   +0.05%     
===========================================
  Files          147      145       -2     
  Lines        13913    13888      -25     
  Branches      1110     1110              
===========================================
- Hits          9923     9913      -10     
+ Misses        3990     3975      -15     

Flag	Coverage Δ
pact	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e5df7...25cabf5. Read the comment docs.

[cpate4]

me, personally, I would not add the branch name to the leonardo-release-tag. it looks like that version is going to find its way into helm charts and a bunch of other downstream systems (not sure if that is intended).

the branch name is also in the "ref" input above.
I would modify the leonardo-build.yaml with the a tag for ${{ inputs.ref }}

[LizBaldo]

Yep, this is the consensus from Devops as well. I will work on it when I have some focus time this week :)

[LizBaldo]

Closing this as we don't need to use the docker tag anymore when updating the leonardo app version on a BEE