Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colors library to support auto-colors based on TTY #611

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

DannyBen
Copy link
Owner

@DannyBen DannyBen commented Jan 20, 2025

cc #600

This PR adds support for auto-color-output based on TTY.
This feature is optional and requires the user to call enable_auto_colors in the initialize.sh, since it somewhat breaks the binary, stict NO_COLOR standard interpretation.

If this is an acceptable solution, I will fix the specs and update the example/tests accordingly.

@DannyBen DannyBen requested review from pcrockett and meleu January 20, 2025 19:11
pcrockett
pcrockett previously approved these changes Jan 20, 2025
Copy link
Collaborator

@pcrockett pcrockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do think this is a pretty good solution. just one suggestion that i have mixed feelings about.

meleu
meleu previously approved these changes Jan 20, 2025
@DannyBen DannyBen dismissed stale reviews from meleu and pcrockett via efb5ad8 January 21, 2025 09:17
@DannyBen DannyBen merged commit 43e0244 into master Jan 21, 2025
9 checks passed
@DannyBen DannyBen deleted the update/colors-tty branch January 21, 2025 09:34
@DannyBen DannyBen added this to the 1.2.9 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants