Adjust docker image to be consistent with multiple cpu arch #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice, thank you for this and the other improvements in the Dockerfile. |
Merged
|
After testing, I cannot accept this PR.
See #486 and #487 - I have added a smoke test for that pandoc version in the docker image, as well as updated the Dockerfile with some of the suggestions in this PR. Shouldn't this fix be done in the dannyben/alpine-ruby base image? |
|
Thank you for the feedback. I think the next step now is just to push the docker image to docker hub for more platforms. |
|
The docker image is not my main focus. It is provided as a convenience. In the meantime, I will push the current image. |
|
Does this seem right? # Create a new builder instance
docker buildx create --name mybuilder
# Set the builder to support multiple platforms
docker buildx use mybuilder
docker buildx inspect --bootstrap
# Build the Docker image for multiple platforms
docker buildx build --platform linux/amd64,linux/arm64 -t myimage:latest . |
|
I think I figured it out. Seems like just something like this: $ docker buildx build --push --platform linux/amd64,linux/arm64 -t dannyben/bashly .which platforms do you need? |
|
I have pushed dannyben/bashly:test to dockerhub, which supports both amd64 and arm64v8 - let me know if it is ok for you, or if you need another platform. |
|
Unfortunately, I not working for my M1:
docker: no matching manifest for linux/arm64/v8 in the manifest list entries.
|
|
Did you try with the bashly image tagged 
I have now also pushed the multi-arch image for the main bashly image. $ docker buildx imagetools inspect dannyben/bashly:1.1.6 |grep Platform
Platform: linux/amd64
Platform: linux/arm64v8 |
|
I have tested in here. The way it worked at my M1 was select platform linux/armd64 and linux/amd64.
Check: https://hub.docker.com/r/brunoselva/bashly/tags
Using this is working just fine at my mac
|
|
I do not understand. https://hub.docker.com/r/dannyben/bashly/tags arm64v8 should be the same as arm64 to my understanding. |
|
Should be: Linux/arm64/v8 or just arm64. Check others like amazoncorretto or debian
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Danny Ben Shitrit ***@***.***>
Sent: Wednesday, February 7, 2024 3:22:02 PM
To: DannyBen/bashly ***@***.***>
Cc: Bruno Selva ***@***.***>; State change ***@***.***>
Subject: Re: [DannyBen/bashly] Adjust docker image to be consistent with multiple cpu arch (PR #485)
External to the Groupe / en provenance de l'extérieur du Groupe
I do not understand.
See the bashly tags - they are the same.
https://hub.docker.com/r/dannyben/bashly/tags
arm64v8 should be the same as arm64 to my understanding.
—
Reply to this email directly, view it on GitHub<#485 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AW5BBO235XYTT6HPAIKLWZTYSPA4VAVCNFSM6AAAAABC2UW4TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGYZDINJQGA>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
------------------------------------------------------------------------
Disclaimer The information in this email and any attachments may contain proprietary and confidential information that is intended for the addressee(s) only. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, retention or use of the contents of this information is prohibited. When addressed to our clients or vendors, any information contained in this e-mail or any attachments is subject to the terms and conditions in any governing contract. If you have received this e-mail in error, please immediately contact the sender and delete the e-mail.
|
|
Does not build. Running yields an error: (same with |
|
Try this:
export DOCKER_BUILDKIT=1
docker buildx create --use
docker buildx build --push --platform linux/arm64,linux/amd64 -t httpd-custom .
docker buildx stop
docker buildx rm
##10 0.064 .buildkit_qemu_emulator: /bin/sh: Invalid ELF image for this architecture
docker run --rm --privileged multiarch/qemu-user-static:register --reset
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
docker buildx rm builder
docker buildx create --name builder --driver docker-container --use
docker buildx inspect –bootstrap
https://hackfi.initedit.com/2022/08/11/push-multi-arch-docker-image/
That fixed my build environment.
I tested using docker and ubuntu jammy with an intel i9
From: Danny Ben Shitrit ***@***.***>
Date: Wednesday, February 7, 2024 at 3:34 PM
To: DannyBen/bashly ***@***.***>
Cc: Bruno Selva ***@***.***>, State change ***@***.***>
Subject: Re: [DannyBen/bashly] Adjust docker image to be consistent with multiple cpu arch (PR #485)
External to the Groupe / en provenance de l'extérieur du Groupe
Does not build.
Running
docker buildx build --platform linux/amd64,linux/arm64/v8 -t dannyben/bashly -t dannyben/bashly:1.1.6 .
yields an error:
Invalid ELF image for this architecture
—
Reply to this email directly, view it on GitHub<#485 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AW5BBOYLDY4EMO4C6GSO7ZLYSPCK3AVCNFSM6AAAAABC2UW4TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGY2DEOJYGQ>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
…------------------------------------------------------------------------
Disclaimer The information in this email and any attachments may contain proprietary and confidential information that is intended for the addressee(s) only. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, retention or use of the contents of this information is prohibited. When addressed to our clients or vendors, any information contained in this e-mail or any attachments is subject to the terms and conditions in any governing contract. If you have received this e-mail in error, please immediately contact the sender and delete the e-mail.
|
|
Tried. Does not change anything. The error still exists. As I mentioned the docker image is provided for convenience and not as a primary focus of this repository. If I bump into a simple solution for this |
|
That is ok! Just trying to help as contributor. If need anything else that I can help, please let me know
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Danny Ben Shitrit ***@***.***>
Sent: Thursday, February 8, 2024 3:30:53 AM
To: DannyBen/bashly ***@***.***>
Cc: Bruno Selva ***@***.***>; State change ***@***.***>
Subject: Re: [DannyBen/bashly] Adjust docker image to be consistent with multiple cpu arch (PR #485)
External to the Groupe / en provenance de l'extérieur du Groupe
Tried. Does not change anything. The error still exists.
As I mentioned the docker image is provided for convenience and not as a primary focus of this repository.
You can either install using Ruby, or build your own docker for your use, as you already did.
If I bump into a simple solution for this Invalid ELF image for this architecture error, I might release the image as multi-arch.
—
Reply to this email directly, view it on GitHub<#485 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AW5BBO5ZYMVLTME7UG736NLYSRWJ3AVCNFSM6AAAAABC2UW4TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGQZTONJZGM>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
------------------------------------------------------------------------
Disclaimer The information in this email and any attachments may contain proprietary and confidential information that is intended for the addressee(s) only. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, retention or use of the contents of this information is prohibited. When addressed to our clients or vendors, any information contained in this e-mail or any attachments is subject to the terms and conditions in any governing contract. If you have received this e-mail in error, please immediately contact the sender and delete the e-mail.
|
Closed
|
Thanks, appreciated. I opened #488. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some experiments, I realized that the current image is locked for x86_64. A simple way to have multiple platforms is by using a more generic base image. This version is actually smaller than the original one as well. Old one 510MB vs 464MB new one