address reviews

DStrand1 · Nov 18, 2024 · 4cdcbf3 · 4cdcbf3
1 parent d1141c5
commit 4cdcbf3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/plugins/inputs/snmp_trap/README.md b/plugins/inputs/snmp_trap/README.md
@@ -63,7 +63,7 @@ details.
   # path = ["/usr/share/snmp/mibs"]
   ##
   ## Timeout running snmptranslate command
-  ## Used by the netsnmp translator
+  ## Used by the netsnmp translator only
   # timeout = "5s"
   ## Snmp version; one of "1", "2c" or "3".
   # version = "2c"

diff --git a/plugins/inputs/snmp_trap/sample.conf b/plugins/inputs/snmp_trap/sample.conf
@@ -15,7 +15,7 @@
   # path = ["/usr/share/snmp/mibs"]
   ##
   ## Timeout running snmptranslate command
-  ## Used by the netsnmp translator
+  ## Used by the netsnmp translator only
   # timeout = "5s"
   ## Snmp version; one of "1", "2c" or "3".
   # version = "2c"

diff --git a/plugins/inputs/snmp_trap/snmp_trap.go b/plugins/inputs/snmp_trap/snmp_trap.go
@@ -84,6 +84,7 @@ func init() {
 		return &SnmpTrap{
 			timeFunc:       time.Now,
 			ServiceAddress: "udp://:162",
+			Timeout:        defaultTimeout,
 			Path:           []string{"/usr/share/snmp/mibs"},
 			Version:        "2c",
 		}
@@ -103,9 +104,6 @@ func (s *SnmpTrap) Init() error {
 			return err
 		}
 	case "netsnmp":
-		if s.Timeout == 0 {
-			s.Timeout = defaultTimeout
-		}
 		s.transl = newNetsnmpTranslator(s.Timeout)
 	default:
 		return errors.New("invalid translator value")