Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-7_x] Remove unused dependencies (webfontloader only) #3510

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

tdonohue
Copy link
Member

Description

Manual port of #3509 to dspace-7_x.

Because dspace-7_x still uses both sortablejs and sanitize-html, this ONLY removes webfontloader.

Instructions for Reviewers

  • Verify tests all still succeed.

@tdonohue tdonohue added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge labels Oct 21, 2024
@tdonohue tdonohue added this to the 7.6.3 milestone Oct 21, 2024
@alanorth alanorth merged commit 8dc777f into DSpace:dspace-7_x Oct 22, 2024
13 checks passed
@alanorth
Copy link
Contributor

All tests passing in CI. I also built and tested locally. The application builds and runs successfully, and simple searching, browsing, etc Angular still work.

@tdonohue tdonohue deleted the remove_unused_deps_7x branch October 22, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

2 participants