Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkspaceitemsEditPageModule: remove duplicated delete route #3234

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

saschaszott
Copy link
Contributor

Description

This PR removes a duplicated /delete route in WorkspaceitemsEditPageModule.

@tdonohue tdonohue added code task 1 APPROVAL pull request only requires a single approval to merge port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Aug 7, 2024
@tdonohue tdonohue added this to the 9.0 milestone Aug 7, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @saschaszott ! This is obviously correct. This exact route code appears twice in the file. Porting also to 8.x as the duplication appears there as well.

@tdonohue tdonohue merged commit f719fde into DSpace:main Aug 7, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@alexandrevryghem alexandrevryghem removed the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge code task
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants